-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conway #20
Conversation
5eb8036
to
9d8150d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with NuFi and this test dApp. Seems to work well 👍
I added one minor naming suggestion comment + I pushed a test case with all the certificates which can be generated by the dApp.
I've stumbled upon an issues I'm not sure how to solve. In NuFi dApp connector we use InteropLib to parse incoming transactions. Then we also try to rebuild the transaction in CSL to make sure we've parsed the tx correctly. Re-serializing an [ 4, null, [], Map(1) { [Array] => 123 }, [ 1, 4 ] ] The This might be a problem for InteropLib as well since you can't parse a transaction and serialize it back if contains a |
91b32af
to
144c43c
Compare
This PR should resolve the above-mentioned issue with tag 30. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the TODOs and missing tests, LGTM.
ddd9057
to
dd8f241
Compare
No description provided.